added time_limit for univariate optimization #1092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot! |
|
Something is failing on macosx master. Not sure why that is. May have to do some searching. Don't think it's related :) |
|
Could you add tests that exercise the methods you added? Thanks |
|
Thanks. I'm running tests and if they pass I'll merge |
|
Thanks again |
avik-pal
pushed a commit
to avik-pal/Optim.jl
that referenced
this pull request
Nov 19, 2024
* added time_limit for univariate optimization * time_limit tests for univariate solvers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#949