[release-1.12] Fix precompilation tests when run from runtests.jl #60201
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In v1.12.1, precompilation output was only suppressed when the JULIA_TESTS environment variable was set. While Base.runtests() sets this variable for the main test process, subprocesses spawned by individual tests (e.g., in test/precompile.jl) did not inherit it, causing unexpected precompilation progress messages in stderr. This minimal fix sets JULIA_TESTS="true" in test/runtests.jl so that all test subprocesses inherit the variable and properly suppress precompilation output. Fixes #59887
vtjnash
approved these changes
Nov 22, 2025
Keno
deleted the
claude/fix-1.12-precompile-output-01WvRzFWXwv3ptkBd75oeTsd
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
precompilationhas a test for the JULIA_TESTS env var that is required to get tests to work. On master, the check was removed in 42a33bb, but on 1.12 it is there and causing problems. Since this is fixed on master, I think the simplest fix is just to set JULIA_TESTS in runtests.jl also on 1.12 to avoid having to mess with the precompilation code itself.Fixes #59887