Fix remove-argument-side-effects with keyword call
#60195
Merged
+35
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix JuliaLang#60152, which impacted both lowering implementations. `remove-argument-side-effects` assumed all `kw` arguments from a `parameters` block had already been dumped into the argument list, which is not true in some cases. In addition: - JuliaLowering hit a MethodError in the dumped-`kw` case regardless. There are other issues with `kw` which I'm ignoring in this PR (see JuliaLang#60162) - Delete some ancient history: `&` [used to be a valid argument](JuliaLang@a378b75#diff-5d79463faae0f7f19454c7f9888498d9f876082e258ab3efdca36a0ee64b0c87L72) head sometime in 2012 apparently!
mlechu
added
compiler:lowering
Keno
reviewed
Nov 22, 2025
| pa_execs = 0 | ||
| kw_execs = 0 | ||
| f60152(v, pa; kw) = copy(v) | ||
| @test (f60152([1, 2, 3], 0; kw=0) .*= 2) == [2,4,6] |
Member
There was a problem hiding this comment.
Should this function do something with the kw, to make sure it actually as the right value?
Member
There was a problem hiding this comment.
Maybe the test below is enough, although it technically tests something slightly different.
Keno
approved these changes
Nov 22, 2025
Contributor
|
Thanks for fixing this! Should the fix be backported? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #60152, which impacted both lowering implementations.
remove-argument-side-effectsassumed allkwarguments from aparametersblock had already been dumped into the argument list, which isnot true in some cases. In addition:
JuliaLowering hit a MethodError in the dumped-
kwcase regardless. There are other issues withkwwhich I'm ignoring in this PR (see BypassSyntaxNodein JuliaLowering; fixkwbug #60162)Delete some ancient history:
&used to be a valid argument head sometime in 2012 apparently!