[release-1.13] Revert "Make banner size depend on terminal size (#51811)" #60186
Conversation
This reverts commit 0f9b2fc. This was also reverted on `master` but after `release-1.13` had branched, so the same change is needed here; without this, the build cannot complete because precompiling REPL deadlocks.
|
And the deadlock only happens when you are building a tagged version? |
|
Do you mean like v1.13.0-alpha1 vs. the commit before it? Edit: nvm, see inline comment below |
| """ | ||
| function banner(io::IO = stdout, preferred::Symbol = :full) | ||
| commit_string = if Base.GIT_VERSION_INFO.tagged_commit | ||
| Base.AnnotatedString(TAGGED_RELEASE_BANNER, :face => :shadow) |
There was a problem hiding this comment.
The specific failure that was getting swallowed and turned into a deadlock was this (courtesy of @xal-0):
Unhandled Task ERROR: UndefVarError: `TAGGED_RELEASE_BANNER` not defined in `REPL`
Suggestion: check for spelling errors or missing imports.
Stacktrace:
[1] banner(io::IO, preferred::Symbol)
@ REPL ~/c/julia-1.13/usr/share/julia/stdlib/v1.13/REPL/src/REPL.jl:1719
[2] run_std_repl(REPL::Module, quiet::Bool, banner::Symbol, history_file::Bool)
@ Base ./client.jl:487
[3] (::REPL.Precompile.var"#repl_workload##11#repl_workload##12"{Base.TTY, Base.TTY, Base.TTY})()
@ REPL.Precompile ~/c/julia-1.13/usr/share/julia/stdlib/v1.13/REPL/src/precompile.jl:144
So this code path requires a tag in order to be exercised and thus observe the failure.
|
Is there an issue that the tagged version won't be the commit that made the VERSION bump? |
Shouldn't be, I don't think, but I can never remember how the tagged commit stuff works in the build system. The only potential oddity I could imagine would be that the version might show up with a trailing |
|
Confirmed it does not have a trailing |
This reverts commit 0f9b2fc. This was also reverted on
master(#59984) but afterrelease-1.13had branched, so the same change is needed here; without this, the build cannot complete because precompiling REPL deadlocks. Thanks to @xal-0 and @IanButterworth for their help in identifying the cause.@KristofferC, given that the current v1.13.0-alpha1 tag is effectively unbuildable, I suggest we delete it and retag once this is merged.