Remove unneeded Base.unsafe_read NoopStream method
#199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Mar 30, 2024
Contributor
vtjnash
left a comment
vtjnash
left a comment
There was a problem hiding this comment.
Sounds good to me. I am no expert though in that. The removal of the eof seems like a bugfix, so may be worth mentioning that in the PR too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what I can tell the
# directly read data from the underlying streambranch is unreachable, so this method is the same as the generic one forTranscodingStream.This PR also removes a redundant call to
eoffromBase.unsafe_read(stream::TranscodingStream:To exit the
whileloop withp < p_endtrue,eof(stream)must have returned true on line 397. So there is no reason to checkeofagain on line 403.