improve readbyte performance #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reloading the Buffer from mutable State is very slow, so make a copy in the immutable struct where it is not expensive. Additionally refactor eof into a fast and slow path, so that the fast path is inlined.
nhz2
reviewed
Feb 2, 2024
nhz2
reviewed
Feb 2, 2024
nhz2
reviewed
Feb 2, 2024
vtjnash
force-pushed
the
jn/readbyte-perf
branch
from
1e31cec to
9ab3602
Compare
This was referenced Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each of these 3 changes gives roughly a 2x speedup for me, taking it from 1.6s to 0.4s, vs. BufferedStreams timing of 0.3s vs. IOBuffer timing of 0.15s
Fixes #150
FWIW, reading a larger chunk at a time into a buffer is usually going to be much much faster again, since it can benefit from vectorized copies at each step, but that doesn't mean we cannot attempt to microoptimize some IO functions