Skip to content

Better warning messages #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 31, 2020
Merged

Better warning messages #603

merged 7 commits into from
Aug 31, 2020

Conversation

tlienart
Copy link
Collaborator

@tlienart tlienart commented Aug 31, 2020

Adds significantly improved warning messages when

  • there's a problem with a page var definition
  • there's an issue with RSS generation
  • there's an issue with running code
  • there's an issue with using a page var

and a few other such things that were causing often unhelpful warnings.

Addresses #544

Note: can be globally turned off passing the keyword show_warnings=false to serve. These are not Julia warning and so will not be affected by logging levels (and vice versa: using show_warnings=false will only suppress the Franklin-warnings

@tlienart tlienart mentioned this pull request Aug 31, 2020
38 tasks
@tlienart tlienart merged commit 4a3d6fd into master Aug 31, 2020
@tlienart tlienart deleted the warni544 branch September 26, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant