Ensure interpolated variables are garbage-collectable #265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the values interpolated into an
@benchmarkable
are stored in theBenchmark
object rather than interpolated directly into the benchmark code. This ensures that interpolated values can be garbage-collected once theBenchmark
object goes out of scope, in contrast to the current behaviour where values interpolated into a benchmark expression will stick around forever.This PR would solve #127.
MWE demonstrating what works with this PR but fails otherwise: