Skip to content

Conversation

tecosaur
Copy link
Collaborator

When only a single sample is present, show the info on that one result.
Also, use plurals appropriately with sample(s) and evaluation(s).

This should resolve #228.

Sample:

image

When only a single sample is present, show the info on that one result.
Also use plurals appropriately with sample(s) and evaluation(s).
@vchuravy
Copy link
Member

Any possible test?

@tecosaur
Copy link
Collaborator Author

We could probably just add a test that runs a benchmark with one sample

@tecosaur
Copy link
Collaborator Author

I've added a simple test, let me know how that looks to you.

Also, I got your invitation to be a collaborator on this repository, thanks 🙂. Any particular expectations I should be aware of?

@vchuravy
Copy link
Member

Any particular expectations I should be aware of?

Don't break stuff to badly without fixing it ;) Since BenchmarkTools is such a widely used tool a certain amount of conservatism also helps. Ask questions when you are unsure about a change, but otherwise go wild

@vchuravy vchuravy merged commit 53d586b into JuliaCI:master Jul 16, 2021
@tecosaur
Copy link
Collaborator Author

Cool. There's something with Judging I want to try, so I'm thinking I'll make a feature branch and then create a PR when I'm interested in getting people's thoughts on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BenchmarkTools v1.1.0: BoundsError when displaying BenchmarkTools.Trial
2 participants