Skip to content

Conversation

jaakkor2
Copy link
Contributor

Fixes #190

@vchuravy
Copy link
Member

vchuravy commented Jan 20, 2021

That probably goes for all methods being called here, sometime I just do a $func to resolve it to func at the definition time of the macro and not the evaluation point.

@vchuravy vchuravy closed this May 19, 2021
@vchuravy vchuravy reopened this May 19, 2021
@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #191 (1723b2a) into master (5df4174) will increase coverage by 3.30%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
+ Coverage   86.37%   89.68%   +3.30%     
==========================================
  Files           6        6              
  Lines         624      921     +297     
==========================================
+ Hits          539      826     +287     
- Misses         85       95      +10     
Impacted Files Coverage Δ
src/execution.jl 97.43% <100.00%> (+0.54%) ⬆️
src/serialization.jl 95.74% <0.00%> (-4.26%) ⬇️
src/groups.jl 95.95% <0.00%> (-0.25%) ⬇️
src/trials.jl 71.15% <0.00%> (+3.60%) ⬆️
src/parameters.jl 64.70% <0.00%> (+4.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5df4174...1723b2a. Read the comment docs.

@vchuravy vchuravy merged commit 6d8f02c into JuliaCI:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MethodError if variable fld defined before using BenchmarkTools
2 participants