feat: delete bot comment if target comment is deleted #55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prs
Overview
Adds a
runCommentCleanup
function that's called inrunOctoGuideAction
if the payload type is deleted. If the payload has a comment, then the corresponding existing comment is retrieved and deleted.Bot comment deletion notably does not go through the
EntityActor
interface added in #43. Because the "entity" is deleted and not available anymore, many of the methods there don't make sense.Switches a few ancillary functions to take url strings instead of entities, since
runCommentCleanup
doesn't run with a full entity.Also renames the
octoguide
function torunOctoGuideRules
. That's more precisely what it does, and this disambiguates it fromrunCommentCleanup
.🗺️