Skip to content

🐛 Bug: pr-body-not-empty should filter out issue references #94

@JoshuaKGoldberg

Description

@JoshuaKGoldberg

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

If someone puts an issue link like fixes #123 in their PR body, the pr-body-not-empty rule should not consider that a new word.

Actual

I'm seeing that it does. Putting a console.log({ uniqueWords }) in JoshuaKGoldberg/OctoGuideExamples#6:

{ uniqueWords: [ '2' ] }

Additional Info

Maybe the right resolution would be to ignore "words" that are just numbers?

cc @azat-io, what do you think?

🗺

Metadata

Metadata

Assignees

No one assigned

    Labels

    status: accepting prsPlease, send a pull request to resolve this! 🙏type: bugSomething isn't working 🐛

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions