MONITORTOGGLE does not turn on the monitor

[lcarado]

Hi @ezeholz many thanks for this great module and for your support.

You probably already know that in the new version (2.2.2) the MONITORTOGGLE command cannot turn on the monitor (but can turn it off).
I can switch the monitor on and off with MONITORON and MONITOROFF commands.
The MONITORSTATUS command always indicates the monitor is on even if it is off: {"success":true,"monitor":"on"}

http://mm_ip:8080/api/monitor/on: {"success":true,"monitor":"on"}
http://mm_ip:8080/api/monitor/off: {"success":true,"monitor":"off"}
http://mm_ip:8080/api/monitor/status: {"success":true,"monitor":"on"} - It's always on
http://mm_ip:8080/api/monitor/toggle: {"success":true,"monitor":"off"} - It's always off

I run the tvservice status when the monitor is off and on:
pi@raspberryMM:~/MagicMirror $ tvservice -s
state 0x2 [TV is off]

pi@raspberryMM:~/MagicMirror $ tvservice -s
state 0xa [HDMI DMT (28) RGB full 16:10], 1280x800 @ 60.00Hz, progressive

I notice only that in tvservice output [TV is off] the 'off' word is all lowercase but in line 635 of node_helper.js the 'o' is uppercase:
let offArr = ["false","TV is Off","standby"];

I think the problem is correctly recognizing the monitor status but I don't know how to fix.

[ezeholz]

Hey! Thanks for let me know. I'm gonna correct it in a bug fix soon. Since I don't own a RPi MM, I cannot test this things on my own, so I appreciate that you check the code and give me this information. Thanks a lot :D

Edit: Maybe is better to use this bug and update the default turn on and off to vcgencmd. That command it's working for you?

[lcarado]

Hi ezeholz, I'm glad my report is helpful for you.

I can confirm that vcgencmd command works on my raspberry:
vcgencmd display_power 0 (For off)
vcgencmd display_power 1 (For on)
vcgencmd display_power -1 (For status)

[ezeholz]

Thanks for the quick reply. What the status command says when it's on and off? With that, I'll have everything I need to fix this issue.

[lcarado]

Hi ezeholz,
here the status with vcgencmd.
Monitor off:

pi@raspberryMM:~ $ vcgencmd display_power 0
display_power=0
pi@raspberryMM:~ $ vcgencmd display_power -1
display_power=0

Monitor on:

pi@raspberryMM:~ $ vcgencmd display_power 1
display_power=1
pi@raspberryMM:~ $ vcgencmd display_power -1
display_power=1

[ezeholz]

Could you try that update? I feel that both errors are solved, there's no need to use customCommand for the monitor, will use vcgencmd by default. :D
Thanks a lot for your contribution.

[lcarado]

Hi ezeholz,
sorry, same situation.
I change branch with git checkout origin/develop.

With monitor off:
pi@raspberryMM:~ $ vcgencmd display_power -1
display_power=0

the module doesn't recognize the status of monitor off:
http://mm_ip:8080/api/monitor/status: {"success":true,"monitor":"on"}
http://mm_ip:8080/api/monitor/toggle: {"success":true,"monitor":"off"}

I don't see any errors in log or console but I find a line like this every time I do an api/monitor command:
[2020-12-03 23:47:19.001] [LOG]

[ezeholz]

That's strange, seems to not recognize the display_power=0 answer. Let me check a few things and I'll talk to you soon.

[ezeholz]

Hey! Did you use git fetch before the git checkout? Maybe git didn't grab the lasts commits, with fetch you'll receive the last changes.

Edit: Be sure that the HEAD stays in 715dada Monitor System changed