Fix badly exported metronome marks from Sibelius on XML import; Support more symbol fonts used in xml files #583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
changed the title
Jojo-Schmitz
force-pushed
the
3.x-more-xml-fonts
branch
2 times, most recently
from
57b6180 to
26a2c79
Compare
Jojo-Schmitz
force-pushed
the
3.x
branch
2 times, most recently
from
bf247bf to
922a518
Compare
Jojo-Schmitz
commented
Dec 27, 2024
|
|
||
| static const QRegExp tempo(".*([yxeqhVwW])(\\.?)\\s*=[^0-9]*([0-9]+).*"); | ||
| #if QT_VERSION >= QT_VERSION_CHECK(5, 11, 0) | ||
| QStringList tempoMatches = plainWords.split(tempo, Qt::SkipEmptyParts); |
There was a problem hiding this comment.
split is not the right tool for the job here
Jojo-Schmitz
force-pushed
the
3.x-more-xml-fonts
branch
from
26a2c79 to
ebaa773
Compare
Jojo-Schmitz
force-pushed
the
3.x
branch
2 times, most recently
from
9326c7c to
88927e8
Compare
Jojo-Schmitz
force-pushed
the
3.x
branch
18 times, most recently
from
f7ed241 to
4e837e2
Compare
Jojo-Schmitz
force-pushed
the
3.x
branch
2 times, most recently
from
e03471a to
a4d9423
Compare
Jojo-Schmitz
force-pushed
the
3.x
branch
3 times, most recently
from
056b1c3 to
176e209
Compare
Jojo-Schmitz
force-pushed
the
3.x
branch
2 times, most recently
from
ecb56f3 to
2ac34cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of musescore#21587 and musescore#24041