Skip to content

Fix CLI to work without webapi extras #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2025
Merged

Fix CLI to work without webapi extras #476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/busylight/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
from loguru import logger

from . import __version__
from .busyserve import busyserve_cli
from .callbacks import string_to_scaled_color
from .global_options import GlobalOptions
from .manager import LightManager
Expand All @@ -18,7 +17,13 @@
for subcommand in subcommands:
cli.add_typer(subcommand)

cli.add_typer(busyserve_cli)
# Conditionally add busyserve CLI if webapi dependencies are available
try:
from .busyserve import busyserve_cli
cli.add_typer(busyserve_cli)
except ImportError:
# webapi extras not installed, skip busyserve functionality
pass

webcli = typer.Typer()

Expand Down
11 changes: 5 additions & 6 deletions src/busylight/busyserve.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,14 @@
import typer
from loguru import logger

# Check if webapi dependencies are available, fail import if not
try:
import uvicorn
except ImportError as error:
logger.error(f"import uvicorn failed: {error}")
typer.secho(
"The package `uvicorn` is missing, unable to serve the busylight API.",
fg="red",
)
raise typer.Exit(code=1) from None
raise ImportError(
"The package `uvicorn` is missing, unable to serve the busylight API. "
"Install with webapi extras: pip install busylight-for-humans[webapi]"
) from error

busyserve_cli = typer.Typer()

Expand Down