Skip to content
This repository was archived by the owner on Sep 6, 2023. It is now read-only.

Conversation

JimBobSquarePants
Copy link
Owner

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practise as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Squeezed a bit of improved quality out of the Resize Processor. We're now producing the best quality that System.Drawing will allow. Fix #792

In addition I replaced the inline dimension calculation code with the ResizeHelper used in the V3 branch and fixed a long standing issue parsing center coordinates in the web project.

Light on tests but the code is heavily tested in the v3 branch and it's copy/paste so not going to bother adding as the infrastructure isn't present.

@ronaldbarendse
Copy link
Collaborator

I've added some fixes and ensured ResizeLayer is backwards compatible again (no binary breaking change and no swapping of X/Y coordinates), but the ResizeHelper still uses the validated and unambiguous PointF? (currently only as internal property).

Copy link
Collaborator

@ronaldbarendse ronaldbarendse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backwards compatibility is fixed nicely in the latest commit 👍

We only have to check the implementation of the QueryParamParser.Instance.ParseValue<PointF>(...), as invalid center values will now default to 0,0 (initial values of the empty struct).

@ronaldbarendse ronaldbarendse changed the base branch from develop-v2 to support/2.x April 8, 2020 21:02
@ronaldbarendse ronaldbarendse changed the base branch from support/2.x to develop April 8, 2020 21:22
@ronaldbarendse ronaldbarendse changed the title Resize Improvements Resize quality improvements Apr 13, 2020
@ronaldbarendse
Copy link
Collaborator

@JimBobSquarePants This is ready to merge! If you can do a last check, this can be released right away (I've already made a draft release containing all changes and versions to bump/release).

@JimBobSquarePants JimBobSquarePants merged commit 1ee666c into develop Apr 16, 2020
@JimBobSquarePants JimBobSquarePants deleted the js/resize-improvements branch April 16, 2020 14:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resize Quality can be improved.
2 participants