-
-
Notifications
You must be signed in to change notification settings - Fork 497
Resize quality improvements #796
Conversation
src/ImageProcessor.Web/Helpers/QuerystringParser/Converters/PointFConverter.cs
Outdated
Show resolved
Hide resolved
I've added some fixes and ensured |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backwards compatibility is fixed nicely in the latest commit 👍
We only have to check the implementation of the QueryParamParser.Instance.ParseValue<PointF>(...)
, as invalid center values will now default to 0,0 (initial values of the empty struct).
@JimBobSquarePants This is ready to merge! If you can do a last check, this can be released right away (I've already made a draft release containing all changes and versions to bump/release). |
Prerequisites
Description
Squeezed a bit of improved quality out of the Resize Processor. We're now producing the best quality that System.Drawing will allow. Fix #792
In addition I replaced the inline dimension calculation code with the
ResizeHelper
used in the V3 branch and fixed a long standing issue parsing center coordinates in the web project.Light on tests but the code is heavily tested in the v3 branch and it's copy/paste so not going to bother adding as the infrastructure isn't present.