Implement integration test runner for IJ #893
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhelenskiy
requested changes
Nov 19, 2025
Collaborator
zhelenskiy
left a comment
zhelenskiy
left a comment
There was a problem hiding this comment.
Let's wait for #891 first
Collaborator
Author
Can you push it today? I would like to close this task about IJ as soon as possible because I already was waiting for a week for the review. |
Collaborator
You are the reviewer there, so that depends on you. |
#JBRes-6600 Done
ivandev0
force-pushed
the
kylchik/ij_cli
branch
from
abfc304 to
fa6bfad
Compare
zhelenskiy
requested changes
Nov 20, 2025
| "methods": [ | ||
| "testInsertString" | ||
| ], | ||
| "checkRepresentation": true |
Collaborator
There was a problem hiding this comment.
Are you sure the representation is stable to check it?
| fields[fieldName]?.let { return it == FinalFields.FieldInfo.FINAL } | ||
| // If we haven't processed this class yet, fall back to a slow-path, reading the class byte-code. | ||
| collectFieldInformation(internalClassName, fieldName, fields) | ||
| val fieldFound = collectFieldInformation(internalClassName, fieldName, fields) |
Collaborator
There was a problem hiding this comment.
Can you describe why it can be not found?
| include(":integration-test") | ||
| include(":integration-test:common") | ||
| include(":integration-test:lincheck") | ||
| include(":integration-test:trace-debugger") |
Collaborator
There was a problem hiding this comment.
Are you sure it is the right trace?
Comment on lines
+87
to
+95
| fun test() { | ||
| runTest( | ||
| testClassName = ${testCase.className.toLiteral()}, | ||
| testMethodName = ${testCase.methodName.toLiteral()}, | ||
| extraJvmArgs = listOf(${testCase.jvmArgs.joinToString { it.toLiteral() }}), | ||
| commands = listOf(${testCase.gradleCommand.toLiteral()}), | ||
| checkRepresentation = ${testCase.checkRepresentation}, | ||
| ) | ||
| } |
Collaborator
There was a problem hiding this comment.
Suggested change
| fun test() { | |
| runTest( | |
| testClassName = ${testCase.className.toLiteral()}, | |
| testMethodName = ${testCase.methodName.toLiteral()}, | |
| extraJvmArgs = listOf(${testCase.jvmArgs.joinToString { it.toLiteral() }}), | |
| commands = listOf(${testCase.gradleCommand.toLiteral()}), | |
| checkRepresentation = ${testCase.checkRepresentation}, | |
| ) | |
| } | |
| fun test() = runTest( | |
| testClassName = ${testCase.className.toLiteral()}, | |
| testMethodName = ${testCase.methodName.toLiteral()}, | |
| extraJvmArgs = listOf(${testCase.jvmArgs.joinToString { it.toLiteral() }}), | |
| commands = listOf(${testCase.gradleCommand.toLiteral()}), | |
| checkRepresentation = ${testCase.checkRepresentation}, | |
| ) |
Comment on lines
+21
to
+30
| open val fatJarName: String = "trace-recorder-fat.jar" | ||
| open val formatArgs: Map<String, String> = mapOf( | ||
| "format" to "text", | ||
| "formatOption" to "verbose", | ||
| ) | ||
| open val defaultJvmArgs: List<String> = listOf( | ||
| "-Dlincheck.traceRecorderMode=true", | ||
| "-XX:+UnlockExperimentalVMOptions", | ||
| "-XX:hashCode=2", | ||
| ) |
Collaborator
There was a problem hiding this comment.
Suggested change
| open val fatJarName: String = "trace-recorder-fat.jar" | |
| open val formatArgs: Map<String, String> = mapOf( | |
| "format" to "text", | |
| "formatOption" to "verbose", | |
| ) | |
| open val defaultJvmArgs: List<String> = listOf( | |
| "-Dlincheck.traceRecorderMode=true", | |
| "-XX:+UnlockExperimentalVMOptions", | |
| "-XX:hashCode=2", | |
| ) | |
| open val fatJarName: String = "trace-recorder-fat.jar" | |
| open val formatArgs: Map<String, String> = mapOf( | |
| "format" to "text", | |
| "formatOption" to "verbose", | |
| ) | |
| open val defaultJvmArgs: List<String> = listOf( | |
| "-Dlincheck.traceRecorderMode=true", | |
| "-XX:+UnlockExperimentalVMOptions", | |
| "-XX:hashCode=2", | |
| ) | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.