Skip to content

Publishing a message without a handler doesn't add it to the tracked session #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 25, 2024
Merged

Publishing a message without a handler doesn't add it to the tracked session #969

merged 5 commits into from
Jul 25, 2024

Conversation

AlexZeitler
Copy link
Contributor

@AlexZeitler AlexZeitler commented Jul 9, 2024 •
edited
Loading

This PR exposes all states of messages represented via MessageEventType as record collections on ITrackedSession and it's TrackedSession implementation.

It also extends the related docs.

The property Executed is obsoleted in favor of two new properties ExecutionStarted and ExecutionFinished where the latter is replacing the existing Executed collection.

@AlexZeitler AlexZeitler marked this pull request as draft July 9, 2024 17:34
@AlexZeitler
Copy link
Contributor Author

I also obsoleted Executed as we now provide two Execution* properties which are more explicit.

https://github.com/JasperFx/wolverine/pull/969/files#diff-3a23b6e5971bd662b66f03aa14aaa562373fcb6f7d7eb69446d2b91083d84523R67

@AlexZeitler AlexZeitler marked this pull request as ready for review July 12, 2024 10:13
@jeremydmiller jeremydmiller merged commit 6cdbc0f into JasperFx:main Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexZeitler @jeremydmiller