feat(versions): support workspace:* versions

[LudovicSterlin]

Description

pnpm support workspace protocol (workspace:).
I'm using it in my monnorepo with a shared package and other packages that depend on it. When I try to use syncpack in my monorepo it raises erro on the workspace:* version.

This repo LudovicSterlin/pnpm-syncpack is a minimal working example for this issue.

When running

syncpack list-mismatches

You get the error below:

- @pnpm-syncpack/shared: 1.0.0 is developed in this repo at packages/shared/package.json
  workspace:* in dependencies of packages/api/package.json
  workspace:* in devDependencies of packages/app/package.json
  1.0.0 in version of packages/shared/package.json

Versions

Softwares

syncpack --version                                                                                                                                                                      12:59
8.2.4
pnpm --version                                                                                                                                                                          13:01
7.12.0

Machine informations

Model Name:	MacBook Pro
Model Identifier:	MacBookPro16,3
Processor Name:	Quad-Core Intel Core i5
Processor Speed:	1,4 GHz
Number of Processors:	1
Total Number of Cores:	4
Memory:	8 GB
System Firmware Version:	1731.140.2.0.0 (iBridge: 19.16.16066.0.0,0)
OS Loader Version:	540.120.3~19

Suggested Solution

If the version is specified in the local package and everywhere in the monorepo workspace:* is used as the version, just let pnpm handle this and don't raise error or make correction when running fix-mismatches.

Help Needed

Don't really now if this is a bug or if I missed an options or configurations to make pnpm workspace protocol and syncpack run smoothly together.

If this is indeed a feature request, I'll be glad to have some hints on where to start/search to implement it in a PR.

[JamieMason]

Thanks @LudovicSterlin I'll take a look.

I'll know more when I look at this properly but see also #85 as it's loosely related, something in there may or may not help in the meantime.

[LudovicSterlin]

Awesome yes, setting workspace: false fixed it. Thank you
Originally posted by @dhruv-004 in #85 (comment)

Hey same for me here, I just added a .syncpackrc.yaml with just this line:

workspace: false

And no error any more. Thanks a lot 👍 🥳

---

However, to be a little picky I don't find very intuitive to set workspace: false while I'm still using locally developed package.

Also now, the comportment with this setting may cause conflict for people having mixed version and workspace protocol (not my case just thinking out loud, maybe not even a thing) since it let use any version for the shared package like 3.0.0 while the local available package is only 1.0.0 and it changes the workspace:* into 3.0.0.

I think a good thing could be to add in the doc the info that using workspace protocol is possible with workspace: false, may be with a warning on using only this and no mixed semver and workspace protocol.

Thanks for your reactivity. Please tell me if you want me to move what I discussed above into a feature request or a discussion 😉

[JamieMason]

thanks @LudovicSterlin, agree something needs to be done. Please leave that repro up for a while and I'll use it to come up with some test scenarios – I don't use workspace: myself*, so that will be handy to understand how it's used.

* I just make sure the plain versions are in sync within the workspace.

[LudovicSterlin]

Yeah for sure, I just updated a bit the repo so if someone stumbles on it there is the right link for them to come back here.

[JamieMason]

👋🏻 To anyone using "some-package": "workspace:*" versions – why do you use them? What do they offer vs using the same version number as the name property of that package in your workspace? I don't use this feature and with syncpack keeping the versions in sync, don't know of a reason why they'd be used.

Once I understand this functionality better, I'd be in a better place to know whether to do something to support it, or close this issue as not needed.

/cc @vith @aparajita (👍🏻'd this issue)

[vith]

The way I'm using versions in my monorepo, those internal deps are never on an older version of a monorepo package, I intend for them to be always current (the packages aren't published anywhere anyway, so the old version wouldn't be resolvable)

Also, when I'm bumping internal monorepo package versions I'm not using syncpack to do it; I'm using syncpack only while upgrading external dep versions