fix: Inconsistencies in the add button #13786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can include it in the changelog, but we can combine entries if we have multiple prs with small ui changes for consistency. |
koppor
added
the
status: changes-required
Siedlerchr
reviewed
Aug 30, 2025
CHANGELOG.md
Outdated
| @@ -117,6 +117,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv | |||
| - We fixed an issue where "Copy to" was enabled even if no other library was opened. [#13280](https://github.com/JabRef/jabref/pull/13280) | |||
| - We fixed an issue where the groups were still displayed after closing all libraries. [#13382](https://github.com/JabRef/jabref/issues/13382) | |||
| - Enhanced field selection logic in the Merge Entries dialog when fetching from DOI to prefer valid years and entry types. [#12549](https://github.com/JabRef/jabref/issues/12549) | |||
| - We improved consistency in the Add Buttons | |||
There was a problem hiding this comment.
just add the PR as a number/link here as well
Siedlerchr
previously approved these changes
Aug 30, 2025
calixtus
reviewed
Sep 1, 2025
| @@ -9,42 +9,38 @@ | |||
| <?import javafx.scene.layout.VBox?> | |||
| <?import org.jabref.gui.icon.JabRefIconView?> | |||
| <fx:root spacing="10.0" type="VBox" | |||
| xmlns="http://javafx.com/javafx" xmlns:fx="http://javafx.com/fxml" | |||
| xmlns="http://javafx.com/ja\vafx" xmlns:fx="http://javafx.com/fxml" | |||
|
@trag-bot didn't find any issues in the code! ✅✨ |
Siedlerchr
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/JabRef/jabref-issue-melting-pot/issues/784
Steps to test
Basically, this PR addresses the inconsistencies in the usage of pure icon button like
+versus+ Addbutton. The changes involve:Sidenote: The changes are somewhat negligible...? I am not sure if I should still include that in the CHANGELOG.md
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)