Focus "Specify Bib(La)TeX" when Bib(La)TeX is in clipboard #13633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trag-bot[bot]](https://avatars.githubusercontent.com/in/856808?s=60&v=4){kind=small}
| @@ -164,6 +167,8 @@ private void finalizeTabs() { | |||
| approach = NewEntryDialogTab.ENTER_IDENTIFIER; | |||
| interpretText.setText(clipboardText); | |||
| interpretText.selectAll(); | |||
| } else if (clipboardText.split(LINE_BREAK)[0].matches(BIBTEX_REGEX)) { | |||
There was a problem hiding this comment.
Direct array access without bounds checking could lead to ArrayIndexOutOfBoundsException if clipboardText is empty. Should use Optional or safe array access pattern.
There was a problem hiding this comment.
This text won't be empty - if check in line 164 ensures this.
|
@koppor Hi, this one is ready for review. Build failed but nothing related to my changes. |
…aTeX-is-in-clipboard
|
@trag-bot didn't find any issues in the code! ✅✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13597
Focus "Specify Bib(La)TeX" when Bib(La)TeX is in clipboard
Steps to test
Copy following to your clipboard:
@Article{,
author = {Oliver Kopp and Carl Christian Snethlage and Christoph Schwentker},
journal = {TUGboat},
title = {JabRef: BibTeX-based literature management software},
year = {2023},
issn = {0896-3207},
number = {3},
pages = {441--447},
volume = {44},
issue = {138},
ranking = {rank4},
}
Click on the "Add entry using..." button
Specify Bib(La)TeX tab is automatically selected:
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)