Skip to content

Remove level for 2d variables #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Remove level for 2d variables #1163

wants to merge 9 commits into from

Conversation

benjaminmenetrier
Copy link
Contributor

@benjaminmenetrier benjaminmenetrier commented Jun 3, 2025 •
edited by ncrossette
Loading

@ncrossette ncrossette requested a review from kbhargava June 11, 2025 14:32
kbhargava
kbhargava approved these changes Jun 11, 2025
View reviewed changes
Copy link
Contributor

@kbhargava kbhargava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. Looks good and breaks nothing :)
Need to check why one of the check fails.

@ncrossette
Copy link
Contributor

Thanks for doing this. Looks good and breaks nothing :) Need to check why one of the check fails.

CI runner ran out of space:


  285 | end subroutine soca_geom_init
      |                             ^
Fatal Error: error writing to /tmp/ccPx9S9S.s: No space left on device
compilation terminated.

@ncrossette ncrossette added the coordinate merge Ready for merge but needs to be coordinated with other repos label Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncrossette ncrossette ncrossette approved these changes

@kbhargava kbhargava kbhargava approved these changes

@travissluka travissluka Awaiting requested review from travissluka

Assignees
No one assigned
Labels
coordinate merge Ready for merge but needs to be coordinated with other repos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benjaminmenetrier @ncrossette @kbhargava @eap