Skip to content

Use external hal #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Use external hal #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/build-2.x.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
php-versions: ["7.4", "8.0", "8.1"]
drupal-version: ["9.3.x", "9.4.x-dev"]
php-versions: ["8.0", "8.1"]
drupal-version: ["10.0.x-dev", "10.1.x-dev"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"10.0" instead of "10.0.x-dev"


services:
mysql:
image: mysql:5.7
image: mysql:8.0
env:
MYSQL_ALLOW_EMPTY_PASSWORD: yes
MYSQL_DATABASE: drupal
Expand Down
3 changes: 2 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@
}
],
"require" : {
"php": ">=7.4"
"php": ">=8.0",
"drupal/hal-hal": "^1.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For D10, this seems it should be "drupal/hal": "^2" at least per https://www.drupal.org/project/hal

},
"require-dev": {
"phpunit/phpunit": "^8",
Expand Down
8 changes: 4 additions & 4 deletions jsonld.info.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ name: 'JSON-LD'
type: module
description: 'Serializes entities to JSON-LD / LDP for the Islandora Project'
package: Web services
core_version_requirement: ^9
core_version_requirement: ^10
dependencies:
- hal
- serialization
- rdf
- drupal:hal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be hal:hal etc.

- drupal:serialization
- drupal:rdf