Issue 1000 #1001
Merged
Issue 1000 #1001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxp
approved these changes
Dec 20, 2023
|
Are the failing tests something that would be easily fixed in your opinion @ajstanley |
rosiel
added a commit
that referenced
this pull request
Apr 2, 2024
* Change to Boolean logic * added forward slash to path * Made Viewer display configurable --------- Co-authored-by: Rosie Le Faive <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: (Issue 1000)
Release pull requests, etc.)
What does this Pull Request do?
The code's original intent was to set the @Label of the manifest to the title of the requesting view, and if that title was not set, it was to use the title of the node or media. This never worked - a missing slash prevented the node title from being returned. Further, once a node has been given a title, it can only be changed to another title, so it can never be reverted to a condition which allows the (now fixed) node title to display.
These changes add a configuration to allow the user to choose between the View title, the Node title, or nothing at all.
What's new?
Choices!
How should this be tested?
Open a page with Mirador viewer on an Islandora instance with the manifest supplied by the IIIF view. On most Islandora instances this will be
admin/structure/views/view/iiif_manifest Navigate toadmin/config/islandora/iiif` and try each of the settings.Documentation Status
No changes are required.
Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/committers