Skip to content

Recreating the intention of PR #1816 explaining "make not found error" #1995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

ysuarez
Copy link
Contributor

@ysuarez ysuarez commented Dec 5, 2021

Purpose / why

This PR essentially recreates older PR #1816 ("Added "make command not found" failure fix") since that PR's contributor never provided a signed CLA. A few attempts were made to contact the contributor to request a CLA from contributor to no avail, and DIG decided to just recreate the PR. Turns out that this older PR changed file docs/installation/docker-compose.md which was then deleted by PR #1797.

What changes were made?

The content explaining how to solve the make command not found error was moved to the top of docs/installation/docker-troubleshooting.md

I wondered if it should appear also in other spots when users are first asked to run make demo or make local, though it might be best to just be placed in a central location like docs/installation/docker-troubleshooting.md

Verification

Try running make demo or make local without make installed and see if the make installation steps work.

Interested Parties

@Islandora/documentation @Islandora/8-x-committers


Checklist

Pull-request reviewer should ensure the following

  • Does this PR link to related issues?
  • Does the proposed documentation align with the Islandora Documentation Style Guide?
  • Are the changes accurate, useful, free of typos, etc?
  • Does this PR update the last updated on date on the documentation page?

Person merging should ensure the following

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

@ysuarez ysuarez added the Type: documentation provides documentation or asks for documentation. label Dec 8, 2021
@manez manez merged commit e04ff03 into Islandora:main Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: documentation provides documentation or asks for documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants