fix/add tests for validation and ISO 8601 #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxp
approved these changes
Aug 9, 2023
|
Tested the drush command and phpunit on Drupal 10, works as advertised. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #103
What does this Pull Request do?
Addresses issue with date intervals throwing a warning when passed to
EDTF:Utils::iso8601Value. Also updates and adds more tests.(i.e. Regeneration activity, etc.)? No.
How should this be tested?
Short version: tests pass. 👍
Longer version:
drush ev 'print(\Drupal\controlled_access_terms\EDTFUtils::iso8601Value("2023-07/2023-08")."\n");'Additional Notes
An early version of this was accidentally pushed directly to the repo which I then reverted. This PR is the real version.
Interested parties
@Islandora/committers