Skip to content

Conversation

@joshdentremont
Copy link
Contributor

Using the DOMAIN variable for dev will break when DOMAIN variable gets changed for production. This change makes Drupal work the same as the other containers by hardcoding the dev URL and using DOMAIN for the production URL.

Copy link
Contributor

@joecorall joecorall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.env is proposed to no longer be tracked in this repo: #95

@joshdentremont
Copy link
Contributor Author

joshdentremont commented Jun 17, 2025

Even if .env is not tracked, the DOMAIN variable will likely not be set to islandora.dev once a production site is set up. If you change DOMAIN to anything other than islandora.dev your development site won't be accessible.

The idea is that for all the dev containers, they are hardcoded to use islandora.dev but the production containers use DOMAIN, which will be changed to something other than islandora.dev.

This is how the other containers, like fedora and solr, are already set up:
traefik.http.routers.fcrepo_http.rule: &traefik-host-fcrepo-dev Host(fcrepo.islandora.dev)

traefik.http.routers.fcrepo_http.rule: &traefik-host-fcrepo-prod Host(fcrepo-${DOMAIN})

@joshdentremont
Copy link
Contributor Author

This should make the Drupal containers and labels more in line with how the other containers work. It should be tested with a production environment as well to make sure both the dev and production sites work.

@joecorall
Copy link
Contributor

I'd prefer we'd just use DOMAIN everywhere 30e66de

@joshdentremont
Copy link
Contributor Author

Oh, I see what you are saying. So your .env would have different domains in the env for dev and the env for prod. This is a better setup for allowing a staging site to have it's own URL as well.

If that gets merged I think we can close this.

@joecorall joecorall closed this Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants