Access Control for Starter Site #349
Conversation
Enable Delegate script for Cantaloupe
Makefile
Outdated
| $(MAKE) starter-init ENVIRONMENT=starter_dev | ||
| if [ -z "$$(ls -A $(QUOTED_CURDIR)/codebase)" ]; then \ | ||
| docker container run --rm -v $(CURDIR)/codebase:/home/root $(REPOSITORY)/nginx:$(TAG) with-contenv bash -lc 'git clone -b main https://github.com/Islandora-Devops/islandora-starter-site /home/root;'; \ | ||
| docker container run --rm -v $(CURDIR)/codebase:/home/root $(REPOSITORY)/nginx:$(TAG) with-contenv bash -lc 'git clone -b islandora_group https://github.com/kylehuynh205/islandora-starter-site.git /home/root;'; \ |
There was a problem hiding this comment.
I get that this is how to get it running, but we are not helped by committing feature branches into our toolchain!
Makefile
Outdated
| $(MAKE) login | ||
|
|
||
| # make private file directory | ||
| docker-compose exec -T drupal mkdir -p $(CURDIR)/codebase/web/sites/default/private_files |
There was a problem hiding this comment.
Best practice is to create a directory outside of the web root. Otherwise (unless you take careful explicit steps to protect it) all the files will be directly accessible over the internet.
There was a problem hiding this comment.
I moved it out to outside web directory kylehuynh205/islandora-starter-site@7672e77
There was a problem hiding this comment.
Cool. Where is the command that creates the private_files directory?
|
This PR is being marked as stale from inactivity and will be automatically closed in 90 days unless further action is taken. If this PR is still relevant please comment. Please also consider attending the weekly Tech Call to discuss the PR |
Add steps to create private file directory
Enable Delegate script for Cantaloupe