Skip to content

Conversation

rosiel
Copy link
Contributor

@rosiel rosiel commented Dec 15, 2022

Related PR: #237

What does this Pull Request do?

Documents #237 in the README.

What's new?

  • Describes two-step process

  • Moves "Mac problems" section to the bottom (not as relevant today)

  • Harmonized the "Variables" section.

  • Does this change require documentation to be updated? see also Documentation pr:

  • Does this change add any new dependencies? no!

  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? no!

  • Could this change impact execution of existing code? no!

How should this be tested?

  • is it right?
  • is it free of typos etc?

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

@whikloj @alxp

Copy link
Member

@whikloj whikloj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, I didn't see any typos. 👍

@whikloj whikloj merged commit 8c583ea into dev Dec 16, 2022
@whikloj whikloj deleted the rosiel-patch-1 branch December 16, 2022 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants