Remove hard-coded Solr version when generating Drupal solr config. #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosiel
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request do?
Make the Drupal solr config version match the installed version of Solr.
What's new?
When generating the solr_config.zip file, the Drush command now uses the {{ solr_version }} from the inventory rather than the hard-coded "7.1".
(i.e. Regeneration activity, etc.)? No
How should this be tested?
Run the playbook.
Go to /admin/config/search/search-api/server/
Click on the Default Solr Server and default index links. Check that Drupal does not print a warning about out-of-date solr config files
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora-Devops/committers