Master -> Main Rename #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosiel
reviewed
Aug 31, 2020
README.md
Outdated
|
|
||
| Islandora 8 uses JWT for authentication across the stack. Crayfish microservices, Fedora, and Drupal all use them. | ||
| Crayfish and Fedora have been set up to use a master token of `islandora` to make testing easier. To use it, just set | ||
| Crayfish and Fedora have been set up to use a main token of `islandora` to make testing easier. To use it, just set |
There was a problem hiding this comment.
were these tokens changed? I'm guessing not, as this is a deep-within-the-stack use and not a github-branch-related one?
There was a problem hiding this comment.
I think the only thing to change is the term "master" to "main" in the above sentence. The token itself is still "islandora" and behaves the same way.
There was a problem hiding this comment.
in this context, 'main' doesn't seem to convey the same meaning. Would 'universal' or 'global' or 'generic' be applicable?
There was a problem hiding this comment.
Does "default" make sense in this case?
There was a problem hiding this comment.
yeah wasn't sure about that when doing this. i'm good with default 👍
rosiel
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of Islandora/documentation#1595