Compatibility correction #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Vagrant 2.2.3 After 61 minutes of building, I have this working with the proposed changes. Small nitpick: spaces around the equals sign ( |
dannylamb
approved these changes
Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Islandora/documentation#1293
What does this Pull Request do?
Adds compatibility_mode to the VM and changes the upon error behavior.
What's new?
Just the mode and the error behavior
How should this be tested?
Try running the provisions /playbook to see if it works.
To test a failure by changing this line to an non-existent url
src: "https://ftp.drupal.org/files/projects/search_api_solr-8.x-2.0.zip"Additional Notes:
N/A
Interested parties
@Islandora-Devops/committers