-
-
Notifications
You must be signed in to change notification settings - Fork 39
Convert project to esm #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert project to esm #35
Conversation
Hey @IonicaBizau just checking in, if there's anything else to add to the PR so it'll be merged please let me know 🙏 |
@edenhermelin Sorry for the late reply on this — would this be backwards compatible with Thank you very much! |
Hi, The main issue we have is that the Thanks |
Hey @IonicaBizau , I think that might be OK but it depends on the configuration of the project that uses this library. Anyway, the PR allows to update the nested dependency (that fixes the usage for Safari), so I guess that it will be effective to add it as currently there are a lot of people blocked from using the library 😃 |
Thank you for this! I am trying to release the new version soon! |
FYI this is a breaking change and warrants a major version bump as CommonJS packages will no longer be able to |
@@ -1,8 +1,8 @@ | |||
"use strict" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESM files are strict by default
Close #31 (perhaps also close #32 )
This PR updates the project to use ESM and allows to import the new version of the
normalize-url
library