Skip to content

Conversation

edenhermelin
Copy link
Contributor

@edenhermelin edenhermelin commented Apr 14, 2022

Close #31 (perhaps also close #32 )

This PR updates the project to use ESM and allows to import the new version of the normalize-url library

@edenhermelin
Copy link
Contributor Author

Hey @IonicaBizau just checking in, if there's anything else to add to the PR so it'll be merged please let me know 🙏

@IonicaBizau
Copy link
Owner

@edenhermelin Sorry for the late reply on this — would this be backwards compatible with require?

Thank you very much!

@omry-hay
Copy link

Hi,
Any updates on this one?

The main issue we have is that the normalize-url version breaks our application in Safari due to this bug that was merged on version 7.0.1 of normalize-url.

Thanks

@edenhermelin
Copy link
Contributor Author

@edenhermelin Sorry for the late reply on this — would this be backwards compatible with require?

Thank you very much!

Hey @IonicaBizau , I think that might be OK but it depends on the configuration of the project that uses this library. Anyway, the PR allows to update the nested dependency (that fixes the usage for Safari), so I guess that it will be effective to add it as currently there are a lot of people blocked from using the library 😃

@IonicaBizau IonicaBizau merged commit ebb7778 into IonicaBizau:master Jul 18, 2022
@IonicaBizau
Copy link
Owner

Thank you for this! I am trying to release the new version soon!

@privatenumber
Copy link
Contributor

FYI this is a breaking change and warrants a major version bump as CommonJS packages will no longer be able to require() it.

@@ -1,8 +1,8 @@
"use strict"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESM files are strict by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Safari invalid regular expression: invalid group specifier name parse-url at version 6 doesn't work on Safari

7 participants