Skip to content

7.0 does not support [email protected]:org/repo.git #50

@crenshaw-dev

Description

@crenshaw-dev

While trying to upgrade Argo CD to use a newer version of git-url-parse, a failing test showed that there's a limitation in 7.0. It does not support git@ URLs when the domain name contains a hyphen. For example:

[email protected]:my-org/my-repo.git

     ❌ should support [email protected]:my-org/my-repo.git
     Error: Expected { protocols: [ 'file' ], protocol: 'file', port: '', resource: '', user: '', password: '', pathname: '', hash: '', search: '', href: '[email protected]:my-org/my-repo.git', query: {} } to equal { protocols: [ 'ssh' ], protocol: 'ssh', port: '', resource: 'github.my-enterprise.com', user: 'git', password: '', pathname: '/my-org/my-repo.git', hash: '', search: '', query: {}, href: '[email protected]:my-org/my-repo.git' }

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions