Skip to content

Conversation

@zyxkad
Copy link
Collaborator

@zyxkad zyxkad commented Jan 19, 2025

PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION

  • Please check if the PR fulfills these requirements
  • The commit message are well described
  • Docs have been added / updated (for features or maybe bugs which were noted). If not, please update the needed documentation here. Feel free to remove this check if you don't need it
  • All changes have fully been tested
  • What kind of change does this PR introduce? (Bug fix, feature, ...)
    Feature

  • What is the new behavior (if this is a feature change)?
    Remove mainThread descriptor for detectors
    Add getReadyTransferId method
    (All three detectors now sharing same API)

    • getMaxTransferRate() -> number
    • getTransferRateLimit() -> number
    • setTransferRateLimit(rate: number) -> nil
    • getTransferRate() -> long
    • getLastTransferedId() -> string | nil
    • getReadyTransferId() -> string | nil
  • Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)
    Yes. (the methods not block any more so they may need to delay to avoid too long without yielding error)

  • Other information:

abstract XDetector
@zyxkad zyxkad requested a review from SirEndii January 19, 2025 01:11
@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2025

Build Preview

badge

You can find files attached to the below linked Workflow Run URL (Logs).

Name Link
Commit e05f964
Logs https://github.com/IntelligenceModding/AdvancedPeripherals/actions/runs/12849385878
Jar Files AdvancedPeripherals PR 700
Expires At 2025-04-19T02:02:29Z

@SirEndii SirEndii added the 1.19x label Jan 19, 2025
@SirEndii SirEndii added this to the 0.8r milestone Jan 19, 2025
@SirEndii
Copy link
Member

I love the changes and additions
But I will review that tomorrow and your other PRs when my eyes aren't tired

@SirEndii
Copy link
Member

SirEndii commented Jan 20, 2025

Can't complain, looks good to me

@SirEndii SirEndii merged commit 278aab1 into IntelligenceModding:dev/0.8 Jan 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants