Skip to content

Conversation

@hochbaum
Copy link
Contributor

Description

Currently, the tile-drop flag does not respect the initial value of BlockDestroyEvent#willDrop, which is set by the server before the event is fired. As a result, some blocks that would not drop in a vanilla environment end up dropping.

You can reproduce that by doing the following:

  1. Go to a plot which has tile-drop set to true
  2. Spawn a sniffer egg using /setblock ~ ~ ~ minecraft:sniffer_egg[hatch=2]
  3. Wait until the egg hatches

You will notice that the egg block is dropped.

This PR fixes the issue by adding a simple check to ensure PlotSquared only sets willDrop when it is already true, preserving vanilla behavior.

Submitter Checklist

  • Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
  • Ensure that the pull request title represents the desired changelog entry.
  • New public fields and methods are annotated with @since TODO.
  • I read and followed the contribution guidelines.

@hochbaum hochbaum requested a review from a team as a code owner November 14, 2025 18:11
Copy link
Member

@PierreSchwang PierreSchwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PierreSchwang PierreSchwang merged commit 840ef5d into IntellectualSites:main Nov 16, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants