Fix UCAL inconsistencies #9912
Merged
Fix UCAL inconsistencies #9912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remibettan
reviewed
Nov 3, 2021
| { | ||
| try | ||
| { | ||
| std::this_thread::sleep_for(std::chrono::milliseconds(1000)); // W/A that allows for USB2 exposure to settle |
There was a problem hiding this comment.
Please confirm that there is no other way to solve this (like some trigger from the exposure control)
There was a problem hiding this comment.
The other way is to generate a mechanism that will ensure the camera's exposure is stabilized. But since we can't know it from metadata (the exposure value reported is always the same, but the picture itself is changing), it must be done using Computer Vision methods, which is quite complicated.
In the tests, having 500 msec delay was sufficient to make the algorithm converge in more than 90% of cases. So making it 1000 is has some spair time to make sure it will also run smoothly in low-end platforms
Fix hyperlink for user notification not opened due to overlapping textbox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Viewer-specific fixes and refinements:
Tracked on : DSO-17819, DSO-17820