Skip to content

Conversation

@gwen2018
Copy link
Contributor

@gwen2018 gwen2018 commented Aug 10, 2021

This is part b fix to additional issues found when switching between 2d and 3d.

Changes:

  1. release frame resources when switching between 2d and 3d
  2. handle cases when only depth, no rgb, is part of the stream
  3. handle cases when no depth is part of the stream

Tracked on: DSO-16584

@ev-mp ev-mp changed the title fix dso 16584 - resource issue that caused crash when switch between … [Android] - fix resource issue handling issue Aug 11, 2021
@ev-mp ev-mp requested a review from remibettan August 11, 2021 19:26
Copy link
Contributor

@remibettan remibettan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm that the memory profiler has been used in order to check that no leak happens because of these changes.

@gwen2018
Copy link
Contributor Author

@remibettan yes, checked with both memory profiler and process profiler, memory did not leak over time after 200 2d-3d switches. The only time memory increases persistently is the first switch to 3d which we does setup for 3d display. in subsequent 2d-3d switches, memory all recovers - native memory recovers once switch back to 2d. java memory gradually recovers as part of garbage collection.

Copy link
Contributor

@remibettan remibettan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gwen2018, thank you for the support!

@ev-mp ev-mp merged commit 8fd01c4 into IntelRealSense:development Aug 17, 2021
@gwen2018 gwen2018 deleted the android_fix_dso_16584_partb branch February 4, 2025 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants