T265 fix for race condition during pipeline stop. #8561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is effectively the suggested fix in the GH issue below. Thank you @ankyur. IntelRealSense#7276 I've validated the fix works using the following code: // Reproduces T265 Hand on Exit. int main(int, char**) { constexpr std::chrono::seconds timeout{ 1 }; while (true) { // Start rs2::config config; rs2::pipeline pipeline; std::cout << "Entering pipeline.start()" << std::endl; pipeline.start(); std::cout << "Exiting pipeline.start()" << std::endl; std::cout << "Sleeping for 1 second..." << std::endl; std::this_thread::sleep_for(timeout); std::cout << "Entering pipeline.stop()" << std::endl; pipeline.stop(); std::cout << "Exiting pipeline.stop()" << std::endl; } return 0; } Suspect this fix potentially addresses the following open T265 issues as well: IntelRealSense#7553 IntelRealSense#5807 IntelRealSense#6272 IntelRealSense#7555 IntelRealSense#7750
ev-mp
approved these changes
Mar 24, 2021
There was a problem hiding this comment.
@krazycoder2k , thanks for the contribution.
Much appreciated!
This was referenced May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is effectively the suggested fix in the GH issue below. Thank you @ankyur.
#7276
I've validated the fix works using the following code:
// Reproduces T265 Hand on Exit.
int main(int, char**)
{
constexpr std::chrono::seconds timeout{ 1 };
}
Suspect this fix potentially addresses the following open T265 issues as well:
#7553
#5807
#6272
#7555
#7750