Handle exception in uvc_sensor::acquire_power #7604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorodnic
approved these changes
Oct 19, 2020
ev-mp
reviewed
Oct 21, 2020
| _user_count.fetch_add( -1 ); | ||
| LOG_ERROR( "acquire_power failed " ); | ||
| throw; | ||
| } |
There was a problem hiding this comment.
What about void uvc_sensor::release_power() below - could the fix be applicable there as well?
There was a problem hiding this comment.
Its not needed because the fix is for the cases that release_power() didn't call because of exception on acquire_power().
There was a problem hiding this comment.
But is it possible that setting D3 would throw?
maloel
approved these changes
Oct 22, 2020
ev-mp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the reference counter in case that exception throws in acquire_power
Tracked on: RS5-9071