Occlusion bug fix #7131
Occlusion bug fix #7131
Conversation
src/proc/occlusion-filter.cpp
Outdated
| for (int i = 0; i < height; i = i + ROTATION_BUFFER_SIZE) | ||
| auto buffer_size = maxDivisorRange(height, width, 1, ROTATION_BUFFER_SIZE); | ||
|
|
||
| byte *buffer = new byte[buffer_size * buffer_size * SIZE]; |
There was a problem hiding this comment.
I can't see delete[]...
Here managed (RAII) memory is preferred, so please switch to std::vector
src/proc/occlusion-filter.cpp
Outdated
| return a; | ||
| return gcd(b, a % b); | ||
| } | ||
| // Return the gretest common divisor of a |
|
impact on performance? |
| { | ||
| int g = gcd(a, b); | ||
| int res = g; | ||
|
|
Only GCD function could impact performance, but it is not significant. |
Have you measured it? |
yes, these are some prints: With GCD: NO GCD: |
3 participants
Tracked on: RS5-8522
Fixes #6990