on chip calibration bug fixes #6097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorodnic
suggested changes
Mar 25, 2020
common/on-chip-calib.cpp
Outdated
| catch (...) {} | ||
| } | ||
|
|
||
|
|
common/on-chip-calib.cpp
Outdated
| _in_3d_view = _viewer.is_3d_view; | ||
| _viewer.is_3d_view = true; | ||
|
|
||
| config_file::instance().set(configurations::viewer::ground_truth_r, ground_truth); |
There was a problem hiding this comment.
Please use spaces instead of tabs
common/on-chip-calib.cpp
Outdated
| _viewer.is_3d_view = true; | ||
|
|
||
| config_file::instance().set(configurations::viewer::ground_truth_r, ground_truth); | ||
| //ground_truth = _viewer.ground_truth_r; |
There was a problem hiding this comment.
Commented out code should not be checked-in
common/on-chip-calib.cpp
Outdated
| _viewer.is_3d_view = _in_3d_view; | ||
|
|
||
| _viewer.ground_truth_r = ground_truth; | ||
| config_file::instance().set(configurations::viewer::ground_truth_r, ground_truth); |
common/on-chip-calib.cpp
Outdated
|
|
||
| auto health = get_manager().get_health(); | ||
| auto recommend_keep = health > 0.25; | ||
| auto recommend_keep = health > 0.25 || health < -0.25; |
There was a problem hiding this comment.
You can use fabs(health) > 0.25f, it's better
common/ux-window.cpp
Outdated
| config_file::instance().set_default(configurations::viewer::log_to_file, false); | ||
| config_file::instance().set_default(configurations::viewer::log_severity, 2); | ||
| config_file::instance().set_default(configurations::viewer::metric_system, true); | ||
| config_file::instance().set_default(configurations::viewer::ground_truth_r, 2500); |
common/viewer.cpp
Outdated
| is_3d_view = config_file::instance().get_or_default( | ||
| configurations::viewer::is_3d_view, false); | ||
|
|
||
| ground_truth_r = config_file::instance().get_or_default( |
common/viewer.h
Outdated
| bool paused = false; | ||
| bool metric_system = true; | ||
|
|
||
| uint32_t ground_truth_r = 2500; |
There was a problem hiding this comment.
yes, to save the last value the user typed in tare calibration.
src/ds5/ds5-auto-calibration.cpp
Outdated
| int data_sampling = DEFAULT_SAMPLING; | ||
| int apply_preset = 1; | ||
|
|
||
|
|
src/hw-monitor.cpp
Outdated
| { | ||
| auto err_type = static_cast<hwmon_response>(opCodeAsUint32); | ||
| throw invalid_value_exception(to_string() << "hwmon command 0x" << std::hex << opCodeXmit << " failed. Error type: " | ||
| throw invalid_value_exception(to_string() << "hwmon command 0x" << std::hex << opCodeXmit << " failed.\n Error type: " |
There was a problem hiding this comment.
Space after \n is not needed
|
Nicely done. Please update pull-request title and add description with the list of fixes and a DSO number |
dorodnic
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DSO-14650