OpenVINO face detection as part of realsense-viewer #6026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorodnic
reviewed
Mar 12, 2020
common/viewer.cpp
Outdated
|
|
||
| auto get_color = [&]( object_in_frame const & object ) -> ImColor | ||
| { | ||
| ColorIdx & color = id2color[object.id]; |
There was a problem hiding this comment.
id2color[object.id % colors.size()]; ?
There was a problem hiding this comment.
The idea here is that the object ID would be mapped to a color index. You don't normally want two IDs mapping to the same color, and I assumed we know nothing about the nature of the ID.
common/viewer.cpp
Outdated
| if( color < int( colors.size() ) ) | ||
| { | ||
| if( color > 0 ) | ||
| return colors[color].first; |
There was a problem hiding this comment.
Do we have a color for the ID?
yes -> return it
find next available color; found it?
yes -> mark it as used; return it
no -> we have more objects than colors; use the the default!
dorodnic
approved these changes
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked on: DSO-13910