- 
                Notifications
    You must be signed in to change notification settings 
- Fork 4.9k
multi-camera connection #5800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi-camera connection #5800
Conversation
| Hey guys, any timeline on getting this in? This is a long-standing bug for multi-camera users. | 
| Hi @mhkabir | 
| Any updates? | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert the rs-multicam changes
        
          
                examples/multicam/rs-multicam.cpp
              
                Outdated
          
        
      | { | ||
| // Create a simple OpenGL window for rendering: | ||
| window app(1280, 960, "CPP Multi-Camera Example"); | ||
| bool display(true); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example's refactoring to be handled separately from the fix
| Bump. We're facing same issue. Long discussion here #5828 | 
| @doronhi @dorodnic @ev-mp @RealSense-Customer-Engineering Is there a timeline for validating this and getting it in? | 
        
          
                src/linux/backend-v4l2.cpp
              
                Outdated
          
        
      | if (_dev_mutex_cnt[_device_path] < 0) | ||
| { | ||
| _dev_mutex_cnt[_device_path] = 0; | ||
| throw linux_backend_exception("HOW DID WE GET HERE??"); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make constructive comment
| throw linux_backend_exception(to_string() << "Acquire failed"); | ||
| auto ret = lockf(_fildes, F_LOCK, 0); | ||
| if (0 != ret) | ||
| throw linux_backend_exception(to_string() << "Acquire failed"); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will _dev_mutex[_device_path].unlock(); be called in case of exception?
renamed "named_mutex" test to "named_mutex_processes"
…eras from 2 different processes.
….2 are available.
…f, like this scenario, there is not a matching recording for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix a bug concerning connection to multiple cameras by several threads or processes.
Tracked on: DSO-13745