T265 manual exposure #3992
Merged
T265 manual exposure #3992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add finally to example code for pyrealsense
bfulkers-i
reviewed
May 16, 2019
| { | ||
| if (!manual_exposure) | ||
| throw std::runtime_error("To control exposure you must set sensor to manual exposure mode prior to streaming"); | ||
| SetManualExposure(_tm_dev, value, last_gain); |
There was a problem hiding this comment.
is this missing a microseconds to milliseconds conversion?
|
We definitely do not recommend trying to set exposure manually for T265 tracking performance, but if you are treating T265 as a raw data only sensor this is not an unreasonable thing to adjust. |
ev-mp
approved these changes
Jun 3, 2019
|
@bfulkers-i |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Do not merge]
This PR unlocks T265 manual exposure controls -
TODO: Clean-up