rs usb interface api and implementations added #3639
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorodnic
reviewed
Apr 1, 2019
|
|
||
| std::shared_ptr<device_watcher_usbhost> device_watcher_usbhost::instance() | ||
| { | ||
| if(!_instance) |
There was a problem hiding this comment.
Why not
static std::shared_ptr<device_watcher_usbhost> instance = std::make_shared<device_watcher_usbhost>();
return instance;
?
|
|
||
| void device_watcher_usbhost::notify() | ||
| { | ||
| std::lock_guard<std::mutex> lk(_mutex); |
There was a problem hiding this comment.
Invoking callback under lock, lets discuss
|
|
||
| // libusb_init(&ctx); | ||
| // count = libusb_get_device_list(ctx, &list); | ||
| libusb_init(NULL); |
There was a problem hiding this comment.
Is it ok to work without libusb context?
| auto rc = libusb_get_device_descriptor(device, &desc); | ||
| if (desc.idVendor != 0x8086) | ||
| continue; | ||
| if ((std::find(ds::rs400_sku_recovery_pid.begin(), ds::rs400_sku_recovery_pid.end(), desc.idProduct) == ds::rs400_sku_recovery_pid.end()) && |
There was a problem hiding this comment.
Why not just raise everything under 8086 + Movidious?
There was a problem hiding this comment.
I guess we may encounter non RS Intel devices
| // Copyright(c) 2015 Intel Corporation. All Rights Reserved. | ||
|
|
||
| #ifdef RS2_USE_WMF_BACKEND | ||
| #ifdef WIN32 |
There was a problem hiding this comment.
Won't compile / run on Win7 I fear
There was a problem hiding this comment.
I'm planing to remove all the backend ifdefs and handle that on cmake
| if (!WinUsb_GetDescriptor(handle, USB_CONFIGURATION_DESCRIPTOR_TYPE, 0, 0, (PUCHAR)&cfgDesc, sizeof(cfgDesc), &returnLength)) | ||
| { | ||
| LOG_ERROR("WinUsb_GetDescriptor failed - GetLastError = %d\n" << GetLastError()); | ||
| } |
There was a problem hiding this comment.
And...?
cfgDesc.wTotalLength will be uninitialized if WinUsb_GetDescriptor fails
Need to review error handling flows in all cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.