basic calibration tests #14166
Merged
basic calibration tests #14166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds basic calibration tests for Intel RealSense devices, implementing tests for both On-Chip Calibration (OCC) and Tare calibration flows with various configurations including host assistance modes.
- Implements calibration test framework with OCC and Tare calibration support
- Adds target distance calculation functionality for Tare calibration
- Creates four distinct test cases covering different calibration scenarios
| if occ_json_file is not None: | ||
| try: | ||
| occ_json = open(occ_json_file).read() | ||
| except: |
There was a problem hiding this comment.
Using bare 'except:' clause is not recommended. Specify the exception type(s) you want to catch, such as 'except (IOError, OSError):'.
Suggested change
| except: | |
| except (FileNotFoundError, IOError): |
Copilot uses AI. Check for mistakes.
| if tare_json_file is not None: | ||
| try: | ||
| tare_json = open(tare_json_file).read() | ||
| except: |
There was a problem hiding this comment.
Using bare 'except:' clause is not recommended. Specify the exception type(s) you want to catch, such as 'except (IOError, OSError):'.
Suggested change
| except: | |
| except (IOError, OSError): |
Copilot uses AI. Check for mistakes.
OhadMeir
reviewed
Jul 29, 2025
OhadMeir
reviewed
Jul 29, 2025
OhadMeir
reviewed
Jul 29, 2025
OhadMeir
reviewed
Jul 29, 2025
OhadMeir
reviewed
Jul 29, 2025
OhadMeir
reviewed
Jul 29, 2025
OhadMeir
reviewed
Jul 29, 2025
OhadMeir
reviewed
Jul 29, 2025
OhadMeir
reviewed
Jul 29, 2025
OhadMeir
reviewed
Jul 29, 2025
OhadMeir
reviewed
Jul 29, 2025
OhadMeir
reviewed
Jul 29, 2025
OhadMeir
reviewed
Jul 29, 2025
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
alexk1976
force-pushed
the
akunin/test_calib
branch
from
b87be16 to
3c7dce4
Compare
OhadMeir
reviewed
Aug 10, 2025
OhadMeir
reviewed
Aug 10, 2025
OhadMeir
reviewed
Aug 10, 2025
OhadMeir
reviewed
Aug 10, 2025
OhadMeir
reviewed
Aug 10, 2025
OhadMeir
reviewed
Aug 10, 2025
OhadMeir
reviewed
Aug 10, 2025
OhadMeir
reviewed
Aug 10, 2025
OhadMeir
reviewed
Aug 10, 2025
OhadMeir
reviewed
Aug 10, 2025
OhadMeir
reviewed
Aug 10, 2025
OhadMeir
reviewed
Aug 10, 2025
OhadMeir
reviewed
Aug 10, 2025
OhadMeir
reviewed
Aug 10, 2025
OhadMeir
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.