stabilize got-playback-frames #14065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Jun 12, 2025
| recorder.pause() | ||
|
|
||
| stop_sensor(depth_sensor) | ||
| stop_sensor(color_sensor) |
There was a problem hiding this comment.
Who is closing now?
The test will end with the resource open?
This hides an SDK BUG you think?
There was a problem hiding this comment.
This is just to use the existing function to stop and close each sensor
I'm not sure this is a bug, it depends on how we expect to use the recorder, when we destroy the recorder we call rs2_delete_device, IMO it's okay
There was a problem hiding this comment.
Oh I get it now, missed that it's a function :)
Nir-Az
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked on: [LRS-1267]