Handle D400 calibrations that need advanced mode #14059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Jun 10, 2025
| # Some calibrations require changing of advanced mode presets (depends on calibration parameters/type) | ||
| am_device = rs.rs400_advanced_mode(device) | ||
| if not am_device or not am_device.is_enabled(): | ||
| print('Camera "Advanced Mode" must be enabled before calibrating.') |
There was a problem hiding this comment.
Since this is an automatic test, can you add the missing command to enter advanced mode to the print?
Nir-Az
approved these changes
Jun 11, 2025
Nir-Az
added a commit
to Nir-Az/librealsense
that referenced
this pull request
Jun 11, 2025
…need advanced mode (cherry picked from commit 8e1d607)
OhadMeir
added a commit
that referenced
this pull request
Jun 11, 2025
…0 calibrations that need advanced mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked on [RSDSO-20283]