Change GLSL for processing to default off #14021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
commented
May 22, 2025
common/ux-window.cpp
Outdated
| // while this can be worked-around, this will take more development time, | ||
| // so for now Macs should not use the GLSL stuff | ||
| config_file::instance().set_default(configurations::performance::glsl_for_processing, false); | ||
| //config_file::instance().set_default(configurations::performance::glsl_for_processing, false); |
There was a problem hiding this comment.
I comment out the placed that set it because it has special logic if it's MAC or not
There was a problem hiding this comment.
I am not sure about removing it or keep it commented out, thoughts?
There was a problem hiding this comment.
Don't remove. It's an historical investigation we won't have time and resources to re-investigate if users will complain about again. I would even leave uncommented.
OhadMeir
reviewed
May 25, 2025
common/ux-window.cpp
Outdated
| config_file::instance().set_nested_default(configurations::dds::enable_dds, false); | ||
| config_file::instance().set_nested_default(configurations::dds::domain_id, 0); | ||
|
|
||
| // Since we have seen on severan laptops models that using GLSL for processing cause a memory leak Decided to disable it by default |
There was a problem hiding this comment.
Minor. If doing other changes in the file. Typo "severan". "Decided" does not need capital letter.
OhadMeir
approved these changes
May 25, 2025
|
I changed the order and fix the typos, please re-review |
OhadMeir
approved these changes
May 25, 2025
Nir-Az
pushed a commit
to Nir-Az/librealsense
that referenced
this pull request
May 25, 2025
…lt to off (cherry picked from commit e9e0bb6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen that several laptops consume high memory and even gets a memory leak when GLSL for processing feature in the RS viewer is ON.
This will disable it by default, user can still turn it on if he likes.
Tracked on [LRS-1266]